Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping leads to async/double playback jumping around #24

Open
nomisum opened this issue Oct 15, 2018 · 3 comments
Open

skipping leads to async/double playback jumping around #24

nomisum opened this issue Oct 15, 2018 · 3 comments
Labels

Comments

@nomisum
Copy link
Contributor

nomisum commented Oct 15, 2018

No description provided.

@nomisum nomisum added the bug label Oct 15, 2018
@McDiod
Copy link
Contributor

McDiod commented Oct 15, 2018

Where in the code is the skipping handled?

@nomisum
Copy link
Contributor Author

nomisum commented Oct 15, 2018

should be in here 🤔

https://github.com/gruppe-adler/grad-replay/blob/master/functions/player/fn_onPlaybackPosChanged.sqf#L5

and here (admin)

[grad_replay_playbackPosition] remoteExec ["GRAD_replay_fnc_syncPlaybackPos", [0,-2] select isDedicated, false];

@nomisum
Copy link
Contributor Author

nomisum commented Oct 19, 2018

todo:

  • necessary sync only when (onplaybackposchanged)
  • add catch for multiple firings of EH
  • prevent multiple executions of replay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants