Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different periods for recitations? #224

Open
civiliangame opened this issue Jul 8, 2016 · 4 comments
Open

Different periods for recitations? #224

civiliangame opened this issue Jul 8, 2016 · 4 comments
Labels

Comments

@civiliangame
Copy link

image

This shows the recitations to be way longer than what is advertised on the CWRU schedules.

image

As you can see here, the Jolly Advisor says that recitations are 1:15 minutes each while the CWRU homepage claims that they are 50 minutes each.
Thanks!
Phillip

@JKobyP JKobyP added the bug label Jul 8, 2016
@JKobyP
Copy link
Contributor

JKobyP commented Jul 8, 2016

I've successfully reproduced the bug. @ajm188 sounds like a SIS syncing problem?

@ajm188
Copy link
Member

ajm188 commented Jul 8, 2016

@thehunter9709 thanks for reporting!

@JKobyP, indeed. The SIS syncing is currently additive only. So, if a course changes it's time length, we wouldn't pick that up automatically, since in a way we would "delete" the old time and add the new time.

I am also wondering: is it possible this is data from the wrong semester/year?

@JKobyP
Copy link
Contributor

JKobyP commented Jul 12, 2016

@ajm188 If your question is toward whether this is human error, I'll tell you I paid particular attention to that, because that was my first assumption when the bug was posted.

We can close this as duplicate then, I suppose. But we need to figure out how to fix our additivity issue. It's not a feature that's working for us.

@StephHippo
Copy link
Member

Weighing in, but this was a design issue that was discussed at length in the beginning. We ended up going with additive (which everyone agreed wasn't a fantastic long-term solution) because of the difficulties in uniquely identifying recitations when they changed. That being said, we know a little more about SIS data now, so it's probably overdue to revisit it.

Looks like the model could be extended to include a recitation ID. Does anyone know how often those change when the time of the recitation changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants