Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmerge divide zero error #315

Open
genostack opened this issue Oct 15, 2021 · 2 comments
Open

lmerge divide zero error #315

genostack opened this issue Oct 15, 2021 · 2 comments

Comments

@genostack
Copy link

we have 1000 samples and when lmerge after lsort, lmerge:213 report divide zero error.
some debug info:

combine_pdfs(BP, c ,use_product, weighting_scheme)
image
a_L[0] p_L[0] on lmerge:128
image
miss=1 on lmerge:181
image

I doubt it may be caused by the "unweighted" scheme? and all the BP has no internals?

@genostack
Copy link
Author

another question about lmerge:213
sum_L = sum(p_L)
sum_R = sum(p_R) not used
p_L = [x/sum_L for x in p_L]
p_R = [x/sum_L for x in p_R] sum_L used twice
on this line sum_R is not used and sum_L is used both on R and L ,is this what we wanted?

@genostack
Copy link
Author

after some debugging I found we have a BP cause this issue:
image
I need some time to find why this BP has a zero p value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant