Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS information into logs/debug output for ld-decode-tools and ld-decode #782

Open
simoninns opened this issue Aug 27, 2022 · 4 comments
Labels
enhancement ld-decode An issue only affecting the ld-decode[r] ld-decode-tools An issue only affecting the ld-decode-tools

Comments

@simoninns
Copy link
Collaborator

Since there are many users running in unsupported environments it is getting really hard to tell if issue reports are really issues at all. The ld-decode tools (and probably ld-decode) should report the underlying OS and version in all debug so if bugs are reported on unsupported systems they can be pushed to the port maintainer for first-pass analysis.

@simoninns simoninns added enhancement ld-decode-tools An issue only affecting the ld-decode-tools ld-decode An issue only affecting the ld-decode[r] labels Aug 27, 2022
@happycube
Copy link
Owner

happycube commented Aug 29, 2022

This turns out to be a pretty easy change using the platform library. The output for Linux isn't as good as using /etc/lsb-release, but it should always work.

@happycube
Copy link
Owner

happycube commented Aug 29, 2022

Done, at least for the json file. missed the debug logs.

@happycube happycube reopened this Aug 29, 2022
@simoninns
Copy link
Collaborator Author

I need to modify the tools output too... So note when ld-decode is done and I'll update when ld-decode-tool match... then we can close.

@harrypm
Copy link
Collaborator

harrypm commented Dec 7, 2023

It would be good if this also stores inital command used for decoding aswell so user error can be easily catched/pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ld-decode An issue only affecting the ld-decode[r] ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Development

No branches or pull requests

3 participants