Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fftfilt is half-strength on FIR filters - check 0.5mhz and audio RF FIR filters #878

Open
happycube opened this issue Jan 28, 2024 · 0 comments

Comments

@happycube
Copy link
Owner

happycube commented Jan 28, 2024

While working on comb filters and setting up standalone overlap/merge fft code, I found out that FIR filters need to be doubled (by using (filtfft(filter) ** 2.0). There are thankfully only two such filters to look at.

(Thankfully, FFT filtering on IIR filters as implemented is accurate to within .0005 on 16-bit decoded video!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant