Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-chroma-encoder json output has wrong sample rate for line locked PAL output. #898

Open
ali1234 opened this issue Aug 24, 2024 · 0 comments
Labels

Comments

@ali1234
Copy link

ali1234 commented Aug 24, 2024

To reproduce:

  1. Get some image and resize and convert it to RGB48 with ffmpeg:

    ffmpeg -i in.png -vf scale=928:576 -f rawvideo -pix_fmt rgb48 out.raw

  2. Convert to TBC with and without -c option:

    tools/ld-chroma-decoder/encoder/ld-chroma-encoder out.raw out.cvbs-ll
    tools/ld-chroma-decoder/encoder/ld-chroma-encoder -c out.raw out.cvbs-sl

Now out.cvbs-sl.json contains:

    "isSubcarrierLocked":true,
    "sampleRate":17734475

As far as I am aware, this is correct.

But out.cvbs-ll.json contains:

    "isSubcarrierLocked":false,
    "sampleRate":17734475

My understanding is that the sample rate should be 17734375, exactly 100Hz less.

I have not yet checked whether the actual output samples are correct in either case.

@ali1234 ali1234 added the bug label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant