Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: "sender", when paying token transfer fees, needs to be clarified to take allowances into account #746

Open
david-bakin-sl opened this issue Jul 24, 2024 · 0 comments

Comments

@david-bakin-sl
Copy link
Member

david-bakin-sl commented Jul 24, 2024

Documentation at https://docs.hedera.com/hedera/sdks-and-apis/sdks/token-service/custom-token-fees, specifically:

Fixed Fee: Paid by the sender of the fungible or non-fungible tokens. A fixed fee transfers a set amount to a fee collector account each time a token is transferred, independent of the transfer size. This fee can be collected in HBAR or another Hedera token but not in NFTs.

and also any other reference to "sender" does not take into account allowances where the token owner has allowed someone else to send on his behalf.

It can therefore be unexpected that the actual transaction "sender", of a transaction not signed by the token owner, can take fees out of the token owner's account. But what's happening is the actual transaction "sender", having an allowance from the owner, has been authorized by the owner to do so.

Suggest: Documentation be clarified to mention this (and perhaps point to other documentation on allowances/approvals).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant