Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check before giving freeze account more HBAR #475

Open
Tracked by #50
jeromy-cannon opened this issue Aug 9, 2024 · 0 comments
Open
Tracked by #50

Add check before giving freeze account more HBAR #475

jeromy-cannon opened this issue Aug 9, 2024 · 0 comments
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete.

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Aug 9, 2024 •
edited
Loading

Currently in node.mjs.prepareUpgradeNetworkNodes() we will always add more HBAR to the freeze account:

solo/src/commands/node.mjs

Line 665 in 39c9792

await this.accountManager.transferAmount(constants.TREASURY_ACCOUNT_ID, FREEZE_ADMIN_ACCOUNT, 100000)

Instead, we should check to see if the freeze account already has enough funds before giving it more.
@jeromy-cannon jeromy-cannon mentioned this issue Aug 9, 2024
Open
@jeromy-cannon jeromy-cannon added P3 Low priority issue. Will not impact the release schedule if not complete. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete.
Projects
Solo
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeromy-cannon