Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: allow continuous synth applications #3205

Closed
1 task
froazin opened this issue Oct 23, 2023 · 4 comments
Closed
1 task

Configuration: allow continuous synth applications #3205

froazin opened this issue Oct 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@froazin
Copy link

froazin commented Oct 23, 2023

Description

Hi!

I think it would be helpful if the cdktf.json file did not enforce the "app" field, but instead returned something like "this application does not support synthesizing via the cli, to use cdktf synth, add an app field to cdktf.json" or something similar.

I'm working on a small PoC project whereby I'm using CDKTF running behind a rest api: the point of which is to synthesize new TF configurations depending on the args supplied via rest call and drop the synthed config into a directory where a worker process then picks up the config, deploys it and checks/corrects drift with terraform-exec. The intention is that this can sit behind an internal developer platform allowing users to quickly and easily deploy applications from a GUI and the likes with little-to-no effort.

image

Given this is a rest api, the app field here is misleading to future maintainers or users of the project. It's something we can just solve with documentation for sure - but the above would effectively serve as a safety catch :)

References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@froazin froazin added enhancement New feature or request new Un-triaged issue labels Oct 23, 2023
@froazin froazin changed the title COMPONENT: allow continuous sync applications COMPONENT: allow continuous synth applications Oct 23, 2023
@ansgarm
Copy link
Member

ansgarm commented Oct 26, 2023

Hi @froazin 👋

Interesting idea! You should be able to achieve such a warning on your own by supplying
"app": "echo 'Warning: This application is not supposed to be invoked via the CDKTF CLI' && exit 1"

@froazin
Copy link
Author

froazin commented Oct 30, 2023

This is one of those times where you facepalm in slow motion 🤣 Thanks @ansgarm I will do that!

@froazin
Copy link
Author

froazin commented Oct 30, 2023

Closing this as @ansgarm's suggestion makes much more sense

@froazin froazin closed this as completed Oct 30, 2023
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
@DanielMSchmidt DanielMSchmidt removed the new Un-triaged issue label Jan 15, 2024
@xiehan xiehan changed the title COMPONENT: allow continuous synth applications Configuration: allow continuous synth applications Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants