Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdktf-cli: support local --template files #3656

Open
1 task done
icholy opened this issue Jun 20, 2024 · 1 comment · May be fixed by #3746
Open
1 task done

cdktf-cli: support local --template files #3656

icholy opened this issue Jun 20, 2024 · 1 comment · May be fixed by #3746
Labels
enhancement New feature or request new Un-triaged issue

Comments

@icholy
Copy link
Contributor

icholy commented Jun 20, 2024

Description

I have some private templates which I don't want to upload anywhere. The --template option allows providing a URL to a zip file. Ideally, I could point it at templates on my local filesystem.

References

#3657

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@icholy icholy added enhancement New feature or request new Un-triaged issue labels Jun 20, 2024
@icholy
Copy link
Contributor Author

icholy commented Oct 20, 2024

After some real-life experience with #3657, what I actually want to do is point it at a template directory. Having the template as a zip committed to the repo is pretty clunky. Also, the way I'm using the file:// scheme is not correct. file:// URIs do not support relative paths.

In light of this, I would like to change the design to work like this:

  • If the template string starts with http(s):// download the zip.
  • If the template string is an exact match to a built-in template, use that.
  • Otherwise treat it like a local directory.

@icholy icholy linked a pull request Oct 20, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new Un-triaged issue
Projects
None yet
1 participant