-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checksum type comparison is case-sensitive #13470
Comments
@calligraf0 great that you did the research and proposed a fix. There was a similar issue earliear at #13466 but it was closed. We're tracking this as well regarding the templates and the box publishing at gusztavvargadr/packer#444. I have moved my boxes recently to the HCP Vagrant Registry, I suspect this might have something to do with the checksum types being returned differently. |
@calligraf0 FYI, I have removed the checksum from all the providers of my boxes for their latest versions to unblock their downloads. The issue can be tested with their previous versions, in case of Windows Server it would be 2102.0.2403. |
Thanks for the heads up! I'm sure I would have gone crazy figuring out why it wouldn't replicate anymore haha! |
This was fixed on the server side and #13471 that @calligraf0 provided was merged as well to add a bit better resiliency on the client side for things like this. My apologies for the issues this has caused. |
Not sure this is a widespred problem, or a problem at all (might be intended behavior).
I couldn't see any other open issue about it.
I worked on a possible fix, I'm opening a PR.
Spoiler alert: I am not too familiar with ruby :) so if I use any unsafe or wrong/deprecated functions: any feedback is welcome!
Debug output
Expected behavior
Comparison should work, regardless of case, since choices are limited to supported checksums anyway.
Actual behavior
While comparing a box checksum vagrant maps the checksum type against this map:
this makes any comparison with a box which specifies the checksum type in UPPERCASE fail to map.
Reproduction information
Vagrant version
2.4.1
Host operating system
Archlinux
Guest operating system
Windows, but shouldn't matter.
Steps to reproduce
gusztavvargadr/windows-server
Vagrantfile
The text was updated successfully, but these errors were encountered: