Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule-add command #127

Open
erikd-ambiata opened this issue Jul 6, 2016 · 4 comments
Open

Add submodule-add command #127

erikd-ambiata opened this issue Jul 6, 2016 · 4 comments

Comments

@erikd-ambiata
Copy link
Contributor

When adding package whatever at lib/whatever it would then check whatever's dependencies and recursively add them as well.

@cartazio
Copy link

cartazio commented Mar 8, 2017

@erikd i've also not been able to find docs for how i can depend on other repos... been trying to dig that up since you mentioned it

@erikd-ambiata
Copy link
Contributor Author

erikd-ambiata commented Mar 8, 2017

The way we currently do it is with git:

mkdir -p lib
git submodule add lib/whatever https://github.com/someone/whatever

and it should just all work.

@erikd-ambiata
Copy link
Contributor Author

Spoke to @jystic about this at lunch. He's not (yet) convinced this is a good idea.

The Pros:

  • The submodule command will be listed in the mafia help output making it easily discoverable.
  • We can add both submodule add and submodule rm, the second of which is a glaring omission in the git submodule command.

The Cons:

  • Ties mafia to git (but no more so that is already the case).

@cartazio
Copy link

cartazio commented Mar 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants