Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility of lock file versioning #200

Open
erikd opened this issue Jan 14, 2018 · 3 comments
Open

Improve flexibility of lock file versioning #200

erikd opened this issue Jan 14, 2018 · 3 comments

Comments

@erikd
Copy link
Contributor

erikd commented Jan 14, 2018

Currently an existing lock file like example.lock-7.10.2 will only be used by mafia with GHC 7.10.2 and will be ignored by GHC 7.10.3.

I would like to keep the above behavior, but add a fallback wildcard-like behavior so that example.lock-X.Y would be accepted as a valid lock file for any GHC version that matches X.Y.*, but only if an exact match (eg X.Y.Z) is not found.

@tmcgilchrist @nhibberd @charleso Any concerns about this?

@nhibberd
Copy link
Member

Nothing comes to mind

@tmcgilchrist
Copy link
Member

Nothing I can think of. Is there ever a situation where minor versions need a different version of a package?

My typical practice was to copy the lock file across to match the GHC version I had within the same major version i.e. 7.10.2 -> 7.10.3 and haven't run into any issues doing that.

@erikd
Copy link
Contributor Author

erikd commented Jan 21, 2018

ghc-prim is one package that can tied to a minor version of that compiler. However, its possible to just leave that out of the lock file and the right thing will happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants