-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version number suggestions seem wrong? #31
Comments
I don't think so. Have you read the spec? It doesn't define what to do with C when you have eg a breaking change. It's up the the maintainer. |
@hasufell I think the issue that @benjaminselfridge wanted to point out is that the flowchart recommends keeping Instead the flowchart should make it clear that the new
|
This was addressed in PR https://github.com/haskell/pvp/pull/20/files. Also a duplicate of issue #25. Suggest to close. Though it would be nice if we could see the enhancements actually deploy to pvp.haskell.org :) |
Remark: More correct would be:
as you do not need to preserve the number of positions in the version string. However, it might be better practice to commit to a fixed number of positions. |
Any chance we could get a new deployment of the repo, since the current version attracts new tickets that are duplicates of this one? |
In the decision flowchart, the major version bump leaf says something like
Your new version number should be (A+1).B.C or A.(B+1).C
Shouldn't it rather say
Your new version number should be (A+1).0.0 or A.(B+1).0
?
The text was updated successfully, but these errors were encountered: