Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version number suggestions seem wrong? #31

Open
benjaminselfridge opened this issue May 8, 2020 · 6 comments
Open

new version number suggestions seem wrong? #31

benjaminselfridge opened this issue May 8, 2020 · 6 comments

Comments

@benjaminselfridge
Copy link

In the decision flowchart, the major version bump leaf says something like

Your new version number should be (A+1).B.C or A.(B+1).C

Shouldn't it rather say

Your new version number should be (A+1).0.0 or A.(B+1).0

?

@hasufell
Copy link
Member

hasufell commented May 9, 2020

I don't think so. Have you read the spec? It doesn't define what to do with C when you have eg a breaking change. It's up the the maintainer.

@sjakobi
Copy link
Member

sjakobi commented May 9, 2020

@hasufell I think the issue that @benjaminselfridge wanted to point out is that the flowchart recommends keeping B and/or C the same when bumping A or B.

Instead the flowchart should make it clear that the new B and/or C are free to choose. Something like this maybe?

Your new version number should be (A+1).B'.C' or A.(B+1).C' where B' and C' may be freely chosen but are usually 0

@benjaminselfridge
Copy link
Author

@hasufell Right -- didn't mean 0 necessarily, but it looks like it's telling you to keep the same B and C after incrementing A.

@sjakobi that's about what I had in mind.

@frasertweedale
Copy link

This was addressed in PR https://github.com/haskell/pvp/pull/20/files.

Also a duplicate of issue #25.

Suggest to close.

Though it would be nice if we could see the enhancements actually deploy to pvp.haskell.org :)

@andreasabel
Copy link
Member

In the decision flowchart, the major version bump leaf says something like

Your new version number should be (A+1).B.C or A.(B+1).C

Shouldn't it rather say

Your new version number should be (A+1).0.0 or A.(B+1).0

Remark: More correct would be:

Your new version number should be (A+1).* or A.(B+1).*

as you do not need to preserve the number of positions in the version string. However, it might be better practice to commit to a fixed number of positions.

@Kleidukos
Copy link
Member

Any chance we could get a new deployment of the repo, since the current version attracts new tickets that are duplicates of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants