Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for operating repos doesn't normalize to lowercase #7

Open
chrisbsmith opened this issue Oct 24, 2019 · 0 comments · May be fixed by #8
Open

Check for operating repos doesn't normalize to lowercase #7

chrisbsmith opened this issue Oct 24, 2019 · 0 comments · May be fixed by #8

Comments

@chrisbsmith
Copy link

I just installed this for a repo with an organization whose name contains mixed case. I did not think to mix the case when I provided the GITHUB_REPO_NAME environment variable. This cased a 403 error with an error of {"message":"Not configured for this repository"}. I updated the organization's name in the environment variable to match the case as found in the payload and then the webhook succeeded.

Recommend normalizing both repoSplit[0] and checkSplit[0] to lowercase for comparison.

if repoSplit[0] != checkSplit[0] {

@chrisbsmith chrisbsmith changed the title Check for operating repos doesn't normalize the lowercase Check for operating repos doesn't normalize to lowercase Oct 24, 2019
@chrisbsmith chrisbsmith linked a pull request Oct 28, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant