Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Should testhtml be updated to show increase in coverage with no change to scraper #1247

Open
jknndy opened this issue Sep 4, 2024 · 1 comment

Comments

@jknndy
Copy link
Collaborator

jknndy commented Sep 4, 2024

for example if updated, bbcfood now includes coverage for category, cuisine, ratings, ratings_count, dietary_restrictions & keywords with a current pull. These are all covered via schema so they require no update to the scraper.

@jknndy jknndy added bug and removed bug labels Sep 4, 2024
@jayaddison
Copy link
Collaborator

Some initial thoughts:

  • Test coverage can be expanded/reduced without requiring any changes to the source code it references; so initially, yes it seems that it's valid to report changes in coverage despite no modification of the recipe scraper.
  • In the case of methods that always directly return the result of calling the recipe scraper's superclass method with the same arguments, I think it's debatable whether the test coverage is exercising the scraper (bbcgood in the example here), or the superclass -- or perhaps both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants