Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor-octokit-api-event-handler #15

Open
colinwilliams91 opened this issue Mar 18, 2024 · 0 comments
Open

refactor-octokit-api-event-handler #15

colinwilliams91 opened this issue Mar 18, 2024 · 0 comments

Comments

@colinwilliams91
Copy link
Contributor

Describe the Problem

The coupling of controllers and operations is kind of redundant the way octokit.api.ts is currently setting up a class.

Currently, router/index.ts handles event registration.

(it's close than when then this ticket was originally written)

Describe the Proposed Solution

Ideas:

octokit.api.ts

/**
 * TODO: IDEA:
 * THIS FILE SHOULD ONLY BE EVENT HANDLER FUNCTIONS THAT CALL octokit (or any?) Controller Functions?
 */

References

Todos inside src\api\octokit.api.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant