Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ior-3.3 lustre support doesn't work with newer lustres #353

Open
glennklockwood opened this issue Mar 27, 2021 · 2 comments
Open

ior-3.3 lustre support doesn't work with newer lustres #353

glennklockwood opened this issue Mar 27, 2021 · 2 comments
Labels
backport Issue whose fix should be backported to previous release bug
Milestone
3.3.1

Comments

@glennklockwood
Copy link
Contributor

Building ior-3.3 --with-lustre correctly identifies lustreapi.h, but parse_options.c only checks for HAVE_LUSTRE_LUSTRE_USER_H. This causes ior to build, link against liblustre, then refuse to honor lustre-specific options.

I haven't checked to see if this works in newer IORs, but it should be fixed in ior-3.3.1.
@glennklockwood glennklockwood added bug backport Issue whose fix should be backported to previous release labels Mar 27, 2021
@glennklockwood glennklockwood added this to the 3.3.1 milestone Jul 7, 2021
@glennklockwood
Copy link
Contributor Author

The fix is simple and available here:

glennklockwood@e49476b

The relevant autoconf bits should be double-checked to make sure these changes don't break Lustre compatibility with older Lustre libraries.

@JulianKunkel
Copy link
Collaborator

Should we maybe define another variable that is set if either HAVE_LUSTRE_LUSTRE_USER_H or HAVE_LUSTRE_LUSTREAPI is set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport Issue whose fix should be backported to previous release bug
Projects
None yet
Milestone
3.3.1
Development

No branches or pull requests
2 participants
@glennklockwood @JulianKunkel