From 536bd2051f7c1417ea916b0a235b400368c2575d Mon Sep 17 00:00:00 2001 From: Howard Pritchard Date: Wed, 19 Jan 2022 19:16:54 -0700 Subject: [PATCH] additional PR feedback Signed-off-by: Howard Pritchard --- ompi/mca/mtl/ofi/mtl_ofi.h | 4 ++-- opal/mca/btl/sm/btl_sm_fifo.h | 2 +- opal/runtime/opal_finalize.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ompi/mca/mtl/ofi/mtl_ofi.h b/ompi/mca/mtl/ofi/mtl_ofi.h index d91ed754c42..e122663db07 100644 --- a/ompi/mca/mtl/ofi/mtl_ofi.h +++ b/ompi/mca/mtl/ofi/mtl_ofi.h @@ -580,8 +580,8 @@ ompi_mtl_ofi_post_recv_excid_buffer(bool blocking, struct ompi_communicator_t *c ofi_req->convertor = NULL; ofi_req->req_started = false; ofi_req->status.MPI_ERROR = OMPI_SUCCESS; - ofi_req->remote_addr = NULL; - ofi_req->match_bits = NULL; + ofi_req->remote_addr = 0UL; + ofi_req->match_bits = 0UL; ofi_req->completion_count = 1; ofi_req->comm = comm; diff --git a/opal/mca/btl/sm/btl_sm_fifo.h b/opal/mca/btl/sm/btl_sm_fifo.h index b7866484f8b..36f497a5dd9 100644 --- a/opal/mca/btl/sm/btl_sm_fifo.h +++ b/opal/mca/btl/sm/btl_sm_fifo.h @@ -157,7 +157,7 @@ static inline bool sm_fifo_write_ep(mca_btl_sm_hdr_t *hdr, struct mca_btl_base_e opal_atomic_wmb(); return mca_btl_sm_fbox_sendi(ep, 0xfe, &rhdr, sizeof(rhdr), NULL, 0); } - mca_btl_sm_try_fbox_setup (ep, hdr); + mca_btl_sm_try_fbox_setup(ep, hdr); hdr->next = SM_FIFO_FREE; sm_fifo_write(ep->fifo, rhdr); diff --git a/opal/runtime/opal_finalize.c b/opal/runtime/opal_finalize.c index f94e037bbcc..94cd775af5b 100644 --- a/opal/runtime/opal_finalize.c +++ b/opal/runtime/opal_finalize.c @@ -111,9 +111,9 @@ void opal_finalize_append_cleanup(opal_cleanup_fn_t cleanup_fn, const char *fn_n (void) fn_name; #endif - opal_mutex_lock (&opal_finalize_cleanup_fns_lock); - opal_list_append (¤t_finalize_domain->super, &cleanup_item->super); - opal_mutex_unlock (&opal_finalize_cleanup_fns_lock); + opal_mutex_lock(&opal_finalize_cleanup_fns_lock); + opal_list_append(¤t_finalize_domain->super, &cleanup_item->super); + opal_mutex_unlock(&opal_finalize_cleanup_fns_lock); } void opal_finalize_domain_init(opal_finalize_domain_t *domain, const char *domain_name)