Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow vsc-install to create correct setup.cfg's #74

Open
JensTimmerman opened this issue Nov 22, 2017 · 2 comments
Open

allow vsc-install to create correct setup.cfg's #74

JensTimmerman opened this issue Nov 22, 2017 · 2 comments

Comments

@JensTimmerman
Copy link
Contributor

the dependencies in setup.cfg for bdist_rpm sometimes need a python prefix, and sometimes don't

we should allow setting the optional prefix in setup.py's install_requires. So we don't need to maintain a separate setup.cfg when all it needs is a python prefix here and there. This way we don't need to maintain version numbers in 2 places.

@stdweird
Copy link
Member

clusterbuildrpm does the prefixing right now. what is not working there?

@JensTimmerman
Copy link
Contributor Author

JensTimmerman commented Nov 22, 2017

pytz is called pytz, not python-pytz, so this breaks when clusterbuildrpm does the prefixing.

other packages include Django-Select2 (not python-django-select2)

We could add all of these as special cases in clusterbuildrpm, or have a flag in setup.py somehwere?
Or like we do now, create a setup.cfg for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants