M1 Failures

[hrbrmstr]

https://www.stats.ox.ac.uk/pub/bdr/M1mac/iptools.out

* using log directory ‘/Users/ripley/R/packages/tests-devel/iptools.Rcheck’
* using R Under development (unstable) (2021-01-09 r79815)
* using platform: aarch64-apple-darwin20.2.0 (64-bit)
* using session charset: UTF-8
* using option ‘--no-stop-on-test-error’
* checking for file ‘iptools/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘iptools’ version ‘0.6.1’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘iptools’ can be installed ... [15s/21s] OK
* checking installed package size ... OK
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... [2s/12s] OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking contents of ‘data’ directory ... OK
* checking data for non-ASCII characters ... NOTE
  Note: found 12 marked UTF-8 strings
* checking data for ASCII and uncompressed saves ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking line endings in Makefiles ... OK
* checking compilation flags in Makevars ... OK
* checking for GNU extensions in Makefiles ... OK
* checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS) ... OK
* checking use of PKG_*FLAGS in Makefiles ... OK
* checking pragmas in C/C++ headers and code ... OK
* checking compilation flags used ... OK
* checking compiled code ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘test-all.R’
 ERROR
Running the tests in ‘tests/test-all.R’ failed.
Complete output:
  > library(testthat)
  > test_check("iptools")
  Loading required package: iptools
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure (test_ip_conversion.R:42:3): Error handlers for numeric to dotted-decimal work ──
  `x` not equal to `expected`.
  1/1 mismatches
  x[1]: "255.255.255.255"
  y[1]: "0.0.0.0"
  
  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 81 ]
  Error: Test failures
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* checking for detritus in the temp directory ... OK
* DONE

Status: 1 ERROR, 1 NOTE
See
  ‘/Users/ripley/R/packages/tests-devel/iptools.Rcheck/00check.log’
for details.

       54.21 real        32.04 user         5.43 sys

[davidaarmstrong]

Hi Bob, I assume that since this was posted 2 years ago, that this isn't a priority to fix, but you can add me to the list of people who would use this if it were resolved. Thanks!

[davidaarmstrong]

I forked the iptools package to see what I could do. Changing the CXX_STD flag to CXX14 from CXX11 in Makevars did the trick. After that, it compiled fine on my M1 Mac (macOS 10.13.1, R v 4.2.2).

[hrbrmstr]

I am more than happy/willing to connect you (or someone/anyone else) with the CRAN folks to pass on the package "maintainer" baton. I submitted the first patch from Dirk, but it borked on one of CRAN's platforms. I fixed that issue as well, and then I got the "hey a couple URLs redirect" note, and there's no way I'm playing tag with future capricious rule changes that have no user community vote or consensus. As such, I have no interest in jumping through their hoops anymore.

…

On Tue, Feb 28, 2023 at 7:40 AM Dave Armstrong ***@***.***> wrote: I forked the iptools package to see what I could do. Changing the CXX_STD flag to CXX14 from CXX11 in Makevars did the trick. — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD4PNTK2WKY62WO4ACPXCLWZXW2BANCNFSM4WCBQK2Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[davidaarmstrong]

Understood - I've made a similar decision with one of my packages that exists only on GitHub now. I just wonder if it might be worth changing the flag on the GitHub version so people who try to install it from here on an M1 might be able to. Alternatively, just leaving the issue open with the comments that show a possible solution might work. The tests that didn't pass weren't problematic for my use of the package. Might be the same for others, too.