Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We can't embed Tweet in doc-builder #497

Open
simoninithomas opened this issue Apr 17, 2024 · 0 comments
Open

We can't embed Tweet in doc-builder #497

simoninithomas opened this issue Apr 17, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@simoninithomas
Copy link
Member

Context: For the ML for Games Course I wanted to embed some tweets from Scenario.gg team that made very good showcase of their features.

However, it seems we can't do it with doc-builder since building the PR lead to errors that seems related to the fact that when we embed a tweet, we add a <script> javascript.

[vite-plugin-svelte] /tmp/tmprl7wke7x/kit/src/routes/unit2/2d-generation/+page.svelte:8:0 A component can only have one instance-level <script> element

I think it's a low-priority feature but it worth mentioning it.

Error message when compiling: https://github.com/huggingface/making-games-with-ai-course/actions/runs/8721509263/job/23925393896#step:12:33

@simoninithomas simoninithomas added bug Something isn't working enhancement New feature or request labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant