-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out core functionality #114
Comments
Part of splitting this out would allow us to potentially offer easier ways to run the linter locally, e.g. |
I have no general objections, but I'm also not sure I understand why you'd like to make the split along those lines. Will our next linter bot not be a Probot and you'd like to keep the |
I'd like to make the linting available for two further purposes:
Beyond that, for the code review stuff I'm working on (see issue linked above), the Probot functionality may need to differ from hm-linter. Rather than making linter-bot infinitely adaptable to try and make that work, splitting into packages should allow that flexibility. |
Got it, thanks for the added clarity! Running these locally would be a huge boon 💯 |
To allow for greater configurability and reuse, I'd like to split the following pieces out into separate packages:
src/linters/
directory into a new@humanmade/linter-core
packagesrc/format.js
andsrc/hooks.js
into a new@humanmade/linter-github
package (and maybe some other bits too)Ideally, I'd like to switch this repo over to a Lerna repo so we don't have to faff about with synchronising packages everywhere, and so that this is basically just a minor internal refactor. I'll need to test that this is working properly with our complex AWS deployment system though.
@mikeselander before I start on this, any objections?
The text was updated successfully, but these errors were encountered: