Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use versions from composer.json and package.json #145

Open
johnbillion opened this issue Nov 23, 2020 · 0 comments
Open

Add ability to use versions from composer.json and package.json #145

johnbillion opened this issue Nov 23, 2020 · 0 comments

Comments

@johnbillion
Copy link
Member

In the Configuration section of the readme it's documented that the version for HM Coding Standards, phpcs, eslint, and stylelint can all be configured.

When I'm using a project that already specifies these versions in composer.json and package.json, I don't want to specify them again here and risk that the versions diverge. This can result in one of the most frustrating types of problems with linting which is when one linting tool displays an error and another doesn't.

It should be possible to instruct linter bot to use the version from these files. An example hmlinter.yml using a mixture of config could look like this:

# GLOBAL SETTINGS

version: 1.1.1

# PER-STANDARD SETTINGS
phpcs:
  enabled: true
  version: composer.json

eslint:
  enabled: true
  version: package.json

stylelint:
  enabled: true
  version: 13.7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant