Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read CS versions from .json files, instead of hmlinter.yml #151

Open
kadamwhite opened this issue Feb 3, 2021 · 0 comments
Open

Read CS versions from .json files, instead of hmlinter.yml #151

kadamwhite opened this issue Feb 3, 2021 · 0 comments

Comments

@kadamwhite
Copy link
Contributor

During discussion on the testing guild call today, we raised that several problems had arisen where linter bot and local linting got out of sync on various projects.

I'd like to propose that if an hmlinter.yml is not present, this bot could check composer.json and package.json if they exist in the project root and infer the correct coding standards versions from those files. We could even read these files even if the yml file is present, so the bot could raise a warning that those versions had drifted out of sync.

@tomjn alternatively suggested that the linter bot could include in its PR comment a post which would list the versions of the dependencies which were used in the bot, and (in a details tag) a snippet for how to run the commands locally.

Either way, we should make it more obvious what version of things is in play, and make it easier for us and Altis clients to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant