Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-consider PHPCS installed_paths argument #97

Open
mikeselander opened this issue Apr 5, 2019 · 2 comments · May be fixed by #123
Open

Re-consider PHPCS installed_paths argument #97

mikeselander opened this issue Apr 5, 2019 · 2 comments · May be fixed by #123
Assignees

Comments

@mikeselander
Copy link
Contributor

As identified in #96, our coding standards <= v0.5.0 cannot handle missing paths gracefully. In v0.6.0 we get improved handling for missing sniffs but we projects are still defaulted to 0.5.0 and we have projects set to run even older versions of the standards.

We need a good way of using newer coding standard sets that we add, such as the VIPCS or the PHPCompatibility standards.

My initial inclination is to parse the standardPath to determine what version is being used and only load in newer standards for 0.6.0 and above. The downside is that this is hacky and we'll have to account for latest being on 0.5.0 for the next month.

Any thoughts @rmccue @kevinlangleyjr?

@rmccue
Copy link
Member

rmccue commented Apr 6, 2019

File exists check and only add it if the standard included it?

@mikeselander
Copy link
Contributor Author

Update on this, as discussed in Slack we should attempt to use the DealerDirect installed_paths where available (per @rmccue)

We can probably drop that bit altogether for newer versions which have dealerdirect right?

Something like if not exists 'vendor/dealerdirect/...' args.push( 'installed_paths', paths )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants