From 0c396eba71fc73fec579ab4e710c81190d12064b Mon Sep 17 00:00:00 2001 From: Danil Nemirovsky <4614623+ameten@users.noreply.github.com> Date: Wed, 30 Oct 2024 16:04:49 +0000 Subject: [PATCH] Add TODO comment to SealevelProvider --- rust/main/chains/hyperlane-sealevel/src/provider.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rust/main/chains/hyperlane-sealevel/src/provider.rs b/rust/main/chains/hyperlane-sealevel/src/provider.rs index ba34cb69c6..a0c5a41ead 100644 --- a/rust/main/chains/hyperlane-sealevel/src/provider.rs +++ b/rust/main/chains/hyperlane-sealevel/src/provider.rs @@ -68,6 +68,12 @@ impl HyperlaneProvider for SealevelProvider { Ok(block_info) } + /// TODO This method is superfluous for Solana. + /// Since we have to request full block to find transaction hash and transaction index + /// for Solana, we have all the data about transaction mach earlier before this + /// method is invoked. + /// We can refactor abstractions so that our chain-agnostic code is more suitable + /// for all chains, not only Ethereum-like chains. async fn get_txn_by_hash(&self, hash: &H512) -> ChainResult { let signature = Signature::new(hash.as_bytes()); let transaction = self.rpc_client.get_transaction(&signature).await?;