You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Where a transaction is created without an override. This is normally acceptable because it is optional, but in our case, we rely on a transactionOverrides config so overrides is always required. We often end up fetching the overrides using this pattern in most of the code:
This is problematic because devs sometimes forget that overrides are required so we end up with unexpected behaviors such as when deploying to Sei and missing maxPriorityFeePerGas:
{"code":-32000,"message":": insufficient fee"}}
Solution
Consider adding a transformation within handleTx() or anywhere else that adds the override because handleTx is often called right after.
Add a linter to make overrides required
Any other solutions where devs don't have to think about adding overrides
Also part of this task is to fix any places that are missing overrides
Perhaps use multiprovider.getTransaction()
The text was updated successfully, but these errors were encountered:
### Description
This partially fixes#4657,
specifically made to get warp apply to work on Sei
### Backward compatibility
Yes
### Testing
Manual - deployed
Problem
In the SDK and other places, we occasionally see this
hyperlane-monorepo/typescript/sdk/src/middleware/account/InterchainAccount.ts
Lines 126 to 132 in 70bb863
hyperlane-monorepo/typescript/sdk/src/router/GasRouterDeployer.ts
Lines 53 to 55 in 70bb863
Where a transaction is created without an
override
. This is normally acceptable because it is optional, but in our case, we rely on atransactionOverrides
config so overrides is always required. We often end up fetching the overrides using this pattern in most of the code:hyperlane-monorepo/typescript/sdk/src/hook/HyperlaneHookDeployer.ts
Lines 357 to 371 in 70bb863
This is problematic because devs sometimes forget that
overrides
are required so we end up with unexpected behaviors such as when deploying to Sei and missingmaxPriorityFeePerGas
:Solution
handleTx()
or anywhere else that adds the override becausehandleTx
is often called right after.overrides
requiredoverrides
overrides
The text was updated successfully, but these errors were encountered: