Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a TODO comment in code #4806

Open
pablin-dev opened this issue Nov 3, 2024 · 0 comments
Open

Implement a TODO comment in code #4806

pablin-dev opened this issue Nov 3, 2024 · 0 comments

Comments

@pablin-dev
Copy link

pablin-dev commented Nov 3, 2024

Problem

Is your feature request related to a problem? Please describe.
When a "cosmos" validator try to announce announce_request, an error occur with Transaction attempting to announce validator reverted. Make sure you have enough funds in your account to pay for transaction fees., but the error result doesn't meant the wallet doesn't have enough funds since its not checked on code. This means that if the announce fails for another reason, an incorrect error message is sent.

Additional context
announce_request
function that does not check the wallet balance

Solution

Describe the solution you'd like
Implement the TODO to assert that the wallet doesnt have enough funds.

Describe alternatives you've considered
None other than knowing the wallet balance.

Nice to Have

Describe non-essential extensions to the solution
Giving more elements on this function tx_response_to_outcome could benefits a better traceability of the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant