Use finality_blocks instead of reorg_period in validator
#532
Assignees
Labels
Comments
|
Hi, |
|
hey @ritikBhandari, amazing please do! I'm happy to answer any questions you may have |
|
Sure. Thanks! |
|
Hey @ritikBhandari, just wondering if you've taken a stab at this? |
Merged
|
Related is also the confirmations field in |
Merged
This was referenced Apr 12, 2023
Closed
|
hey @mattiecnvr is this still in review? |
|
@avious00 |
|
I think this would make sense to do with #2215 |
|
This ended up changing a bit with the new config shapes and we are now using reorg period but it is the one defined in the common chain metadata. |
tkporter
added a commit
that referenced
this issue
Oct 24, 2023
…to edge cases (#2836) ### Description * #532 wasn't actually fully closed out - finality_blocks was used still for indexing. Sadly testnet4 infra wasn't configuring finality blocks anymore, so we weren't indexing only finalized blocks. Moved fully to reorg_period * Refactored `checkpoint_submitter` in light of races revealed by the above ^ problem. It used to assume that message indexing and the `latest_checkpoint()` call would align with one another, and wasn't resilient to the tree already being past the correctness checkpoint. A couple situations were possible before that aren't now: a. Indexing is ahead of the latest_checkpoint() call, which will result in tree ingesting the new indexed messages and the tree being ahead of the correctness checkpoint :( b. It's possible for the tree() call that constructs the tree initially to be made against a block that's after the next latest_checkpoint() call, which would result in the tree being ahead of the correctness checkpoint from the very beginning :( ### Drive-by changes removed a function that wasn't being used anymore ### Related issues #532 ### Backward compatibility Removes finality blocks entirely ### Testing Builds, e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #504,
finality_blockswas added for each ChainConfig. Thereorg_periodin the Validator agent settings is basically a duplicate of this-- we should removereorg_periodin favor offinality_blocksand update theinfrapackage accordinglyThe text was updated successfully, but these errors were encountered: