Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate using CloseableContext in other components than Dialog #1179

Open
lyzadanger opened this issue Aug 2, 2023 · 0 comments
Open

Evaluate using CloseableContext in other components than Dialog #1179

lyzadanger opened this issue Aug 2, 2023 · 0 comments
Labels
needs a think

Comments

@lyzadanger
Copy link
Contributor

https://github.com/hypothesis/frontend-shared/releases/tag/v6.5.0 adds a CloseableContext to the Dialog component, which allows nested components to access a close handler. We might consider adding a CloseableContext to other components that are inherently "close-able", such as Panel or ModalDialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs a think
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lyzadanger