Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Files Are Not Gitignored In Some Generators #187

Closed
harshkhandeparkar opened this issue Mar 6, 2023 · 8 comments
Closed

Generated Files Are Not Gitignored In Some Generators #187

harshkhandeparkar opened this issue Mar 6, 2023 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@harshkhandeparkar
Copy link
Collaborator

Generated files such as .log, .rpt, .odb in flow/, work/, and simulations/run/ are not gitignored for the following generators:

  1. LDO: No files are gitignored
  2. Temperature Sensor: simulations/run/ is not gitignored.
@harshkhandeparkar
Copy link
Collaborator Author

I was going through the documentation and came across this while running the LDO generator.
I am currently learning about the tool and hoping to contribute in the future so may I work on a fix for this?

@lulu9312
Copy link
Contributor

lulu9312 commented Mar 9, 2023

@harshkhandeparkar Sure! you can work on fixing this issue.

@harshkhandeparkar
Copy link
Collaborator Author

I also found that some generated files which were not gitignored are tracked. Should I also untrack these files?

Example: Generated verilog files in ldo-gen and dcdc-gen

@saicharan0112
Copy link
Collaborator

@lulu9312 can you check if we need to prevent these files from version control?

@saicharan0112
Copy link
Collaborator

saicharan0112 commented Mar 10, 2023

@harshkhandeparkar I don't think excluding the folders and files you mentioned is a good idea. Intended users are designers and as far as I know, usually they want these files under version control

@saicharan0112 saicharan0112 added the question Further information is requested label Mar 10, 2023
@lulu9312
Copy link
Contributor

@saicharan0112 The folders that are generated such as logs/ results/ will change everytime the generator is run. So I think those files should not be pushed to github because anyway when running the flow again the files will be created again.

@harshkhandeparkar
Copy link
Collaborator Author

harshkhandeparkar commented Mar 10, 2023

@harshkhandeparkar I don't think excluding the folders and files you mentioned is a good idea. Intended users are designers and as far as I know, usually they want these files under version control

There are templates (which are pushed) for generating these files and they are generated everytime the generator is run and change slightly depending on the configuration. Also there are nearly a hundred files that are generated so I don't think pushing these is a good idea.

@saicharan0112
Copy link
Collaborator

I was going through the documentation and came across this while running the LDO generator. I am currently learning about the tool and hoping to contribute in the future so may I work on a fix for this?

I really appreciate your interest. Can you look at this issue? It would be really wonderful if you can help with this? #37

@saicharan0112 saicharan0112 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants