Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of animated-scroll-to is breaking the build 🚨 #204

Open
greenkeeper bot opened this issue Sep 2, 2019 · 2 comments
Open

An in-range update of animated-scroll-to is breaking the build 🚨 #204

greenkeeper bot opened this issue Sep 2, 2019 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Sep 2, 2019

The dependency animated-scroll-to was updated from 1.2.2 to 1.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

animated-scroll-to is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ci/circleci: Your tests failed on CircleCI (Details).

Commits

The new version differs by 2 commits.

  • 996b064 v1.3.0 - onComplete now gets called even when scroll animation is canceled (#27)
  • 636752b stanko.github.io -> muffinman.io

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Sep 2, 2019

After pinning to 1.2.2 your tests are passing again. Downgrade this dependency 📌.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Sep 14, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 2 commits.

  • fdbf992 v1.3.1 - Fixed if element was scrolling and cancelOnUserAction was passed the whole page couldn't scroll
  • 36efe42 change window to options.element for scroll behaviour (#29)

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants