Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE SOURCE CODE: Merged Repository (for those interested) #193

Open
grexican opened this issue Feb 12, 2019 · 5 comments
Open

UPDATE SOURCE CODE: Merged Repository (for those interested) #193

grexican opened this issue Feb 12, 2019 · 5 comments

Comments

@grexican
Copy link

I have merged in most of the PRs on this branch. I'm still testing, so I haven't merged everything into the master branch yet. But if anyone wants to try things out:
cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

When I merge things back into the main branch, I will let everyone know.

@anotherapj
Copy link

Can you also include #71 along with this.

@grexican
Copy link
Author

Done.

@visortown
Copy link

cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

@grexican Thank you for the efforts. There is an error at installation:
Using "requireCordovaModule" to load non-cordova module "glob" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.

When running on iOS, it encountered an error:
Property 'getCurrentURL' not found on object of type 'CDVThemeableBrowserViewController *'; did you mean 'currentURL'?

@grexican
Copy link
Author

grexican commented Apr 2, 2019

@visortown hmmm ok I'll take a look and get 'er running. No merge conflicts before so I took it for granted that it was good to go.

@hooliy
Copy link

hooliy commented Jul 16, 2019

@grexican very perfect!Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants