Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crash because of memory warning #42

Open
imbaggaarm opened this issue Jul 23, 2018 · 3 comments
Open

App Crash because of memory warning #42

imbaggaarm opened this issue Jul 23, 2018 · 3 comments
Assignees
Labels

Comments

@imbaggaarm
Copy link

Hi, I recently find out a bug, when collection view loads a lot of images, app will crash, can you fix that problem. Thank you. Btw, your library is really great, but can you detail more about How to install it via carthage, or pod, and manually too. Thanks.

@radimhalfar
Copy link
Collaborator

radimhalfar commented Jul 23, 2018

@imbaggaarm Thank you for your support and finding out new bug.

Can you please approx. specify the amount of photos you use to test the issue?
To answer the second part:

For cocoapods - we do not support cocoapods yet - I will file an improvement for it.

For carthage setup Carthage as usually and add
github "inloop/image-picker" to your cartfile. If you would like to specify branch, just use
github "inloop/image-picker" "master". We will definitely look into the memory issue.

@imbaggaarm
Copy link
Author

About 1540 photos, I think we should delete some photos were loaded when scroll up or down, that will fix the problem.

@tankista
Copy link
Contributor

I was able to reproduce this. It looks like when you scroll rapidly app can allocate too much memory at once and system does not release it quickly enough. This should be definitely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants