From 2f4534b51eb696eb818f2915dd174feb87bbc2a1 Mon Sep 17 00:00:00 2001 From: Ryszard Schossler <51096731+LynxLynxx@users.noreply.github.com> Date: Wed, 6 Nov 2024 09:40:51 +0100 Subject: [PATCH] fix(cat-voices): update wallet link button label and localization keys for registration transaction review (#1088) (#1137) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Damian MoliƄski <47773413+damian-molinski@users.noreply.github.com> --- .../wallet_link/stage/roles_summary_panel.dart | 2 +- .../lib/generated/catalyst_voices_localizations.dart | 12 ++++++------ .../generated/catalyst_voices_localizations_en.dart | 6 +++--- .../generated/catalyst_voices_localizations_es.dart | 6 +++--- .../lib/l10n/intl_en.arb | 8 ++++---- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/catalyst_voices/apps/voices/lib/pages/registration/wallet_link/stage/roles_summary_panel.dart b/catalyst_voices/apps/voices/lib/pages/registration/wallet_link/stage/roles_summary_panel.dart index d122ca5dae..c4dfdbebe8 100644 --- a/catalyst_voices/apps/voices/lib/pages/registration/wallet_link/stage/roles_summary_panel.dart +++ b/catalyst_voices/apps/voices/lib/pages/registration/wallet_link/stage/roles_summary_panel.dart @@ -31,7 +31,7 @@ class RolesSummaryPanel extends StatelessWidget { onTap: () { RegistrationCubit.of(context).nextStep(); }, - child: Text(context.l10n.walletLinkRoleSummaryButton), + child: Text(context.l10n.reviewRegistrationTransaction), ), const SizedBox(height: 10), VoicesTextButton( diff --git a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart index f4e0147a5a..356a846fc5 100644 --- a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart +++ b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart @@ -886,12 +886,6 @@ abstract class VoicesLocalizations { /// **' in Catalyst.'** String get walletLinkRoleSummaryContent3; - /// A button label on the role summary screen in registration for the next step. - /// - /// In en, this message translates to: - /// **'Confirm & Sign with wallet'** - String get walletLinkRoleSummaryButton; - /// Message shown when redirecting to external content that describes which wallets are supported. /// /// In en, this message translates to: @@ -1905,6 +1899,12 @@ abstract class VoicesLocalizations { /// In en, this message translates to: /// **'Connect a different wallet'** String get connectDifferentWallet; + + /// A button label to review the registration transaction in wallet detail panel. + /// + /// In en, this message translates to: + /// **'Review registration transaction'** + String get reviewRegistrationTransaction; } class _VoicesLocalizationsDelegate extends LocalizationsDelegate { diff --git a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart index 345aef42d7..4d0879c593 100644 --- a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart +++ b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart @@ -478,9 +478,6 @@ class VoicesLocalizationsEn extends VoicesLocalizations { @override String get walletLinkRoleSummaryContent3 => ' in Catalyst.'; - @override - String get walletLinkRoleSummaryButton => 'Confirm & Sign with wallet'; - @override String get seeAllSupportedWallets => 'See all supported wallets'; @@ -997,4 +994,7 @@ class VoicesLocalizationsEn extends VoicesLocalizations { @override String get connectDifferentWallet => 'Connect a different wallet'; + + @override + String get reviewRegistrationTransaction => 'Review registration transaction'; } diff --git a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart index d14cd87864..c63315deed 100644 --- a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart +++ b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart @@ -478,9 +478,6 @@ class VoicesLocalizationsEs extends VoicesLocalizations { @override String get walletLinkRoleSummaryContent3 => ' in Catalyst.'; - @override - String get walletLinkRoleSummaryButton => 'Confirm & Sign with wallet'; - @override String get seeAllSupportedWallets => 'See all supported wallets'; @@ -997,4 +994,7 @@ class VoicesLocalizationsEs extends VoicesLocalizations { @override String get connectDifferentWallet => 'Connect a different wallet'; + + @override + String get reviewRegistrationTransaction => 'Review registration transaction'; } diff --git a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb index fa5e3dc116..9358da69a7 100644 --- a/catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb +++ b/catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb @@ -595,10 +595,6 @@ "@walletLinkRoleSummaryContent3": { "description": "The last part of the message on the role summary screen in registration." }, - "walletLinkRoleSummaryButton": "Confirm & Sign with wallet", - "@walletLinkRoleSummaryButton": { - "description": "A button label on the role summary screen in registration for the next step." - }, "seeAllSupportedWallets": "See all supported wallets", "@seeAllSupportedWallets": { "description": "Message shown when redirecting to external content that describes which wallets are supported." @@ -966,5 +962,9 @@ "connectDifferentWallet": "Connect a different wallet", "@connectDifferentWallet": { "description": "A button label to connect a different wallet in wallet detail panel." + }, + "reviewRegistrationTransaction": "Review registration transaction", + "@reviewRegistrationTransaction": { + "description": "A button label to review the registration transaction in wallet detail panel." } } \ No newline at end of file