getInstalledWalletExtensions
string returns
#140
Closed
nstanford5
started this conversation in
General
Replies: 1 comment
-
The N for nami in getInstalledWalletExtensions should indeed be lowercase, feel free to make a PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Calling
getInstalledWalletExtensions
returns the name of any installed wallet extensions in a browser window. Currently it returns as follows.."lace"
"eternl"
"Nami"
The issue I had was parsing the return to check for each of these extensions -- I assumed they would return to conform to the
SupportedWalletName
Type, but the return for nami uses a capitalN
.Checking these returns against a set of constants like this..
incorrectly denotes that Nami is not installed. The issue would persist when checking the array of names is a
SupportedWalletName
as well, because the Type denotes below..SupportedWalletName: "nami" | "eternl" | "lace"
Fix: Have
getInstalledWalletExtensions
return"nami"
with a lowercasen
Beta Was this translation helpful? Give feedback.
All reactions