Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving js function from Dashboard to Map #382

Open
ste519 opened this issue Dec 24, 2020 · 5 comments
Open

Moving js function from Dashboard to Map #382

ste519 opened this issue Dec 24, 2020 · 5 comments

Comments

@ste519
Copy link
Collaborator

ste519 commented Dec 24, 2020

On branch feature/368-stories-widget: the task is to move all the js functions from frontend/src/routes/Dashboard/index.js to frontend/src/components/Map/index.js and resolve possible conflicts (this should be a good way to get familiar with the file structures and the stack).

@MuhammadCF
Copy link
Collaborator

Does my objective include only moving the components from one file to another and making sure that the will be no
conflicts rising after or was there an inherent bug in the integration between the react render and the mapbox render
(which might have necessitated this issue to begin with) that I have to take into account as well?

If my memory serves me well In the last meeting I attended (first week of the break), I have heard that there was some sort of dom conflict going on that compels this component-moving, but I forgot the specifics.
@ste519

@ste519
Copy link
Collaborator Author

ste519 commented Jan 12, 2021

Does my objective include only moving the components from one file to another and making sure that the will be no
conflicts rising after or was there an inherent bug in the integration between the react render and the mapbox render
(which might have necessitated this issue to begin with) that I have to take into account as well?

If my memory serves me well In the last meeting I attended (first week of the break), I have heard that there was some sort of dom conflict going on that compels this component-moving, but I forgot the specifics.
@ste519

@MuhammadCF The task is basically moving the components and resolving conflicts. To debug for the rendering problem possibly due to dom conflict is optional, but I would recommend taking a look into it.

@MuhammadCF
Copy link
Collaborator

@ste519 Would it be okay to instead move the components from (frontend/src/components/Map/index.js) To (frontend/src/routes/Dashboard/index.js) i.e. the other way around?

another question: is it to be expected that I am neither able to login/sign up or visit as a guest in this branch (feature/368-stories-widget), or did I somewhat build it incorrectly?

@yls00
Copy link
Collaborator

yls00 commented Jan 14, 2021

@ste519 Would it be okay to instead move the components from (frontend/src/components/Map/index.js) To (frontend/src/routes/Dashboard/index.js) i.e. the other way around?

another question: is it to be expected that I am neither able to login/sign up or visit as a guest in this branch (feature/368-stories-widget), or did I somewhat build it incorrectly?

@MuhammadCF I think it is because of database issue. Probably, your database did not set up. You should follow the every step in the readme, like ./dev-setup and then run docker.

@yls00
Copy link
Collaborator

yls00 commented Jan 26, 2021

Not on the prioritization list anymore.

@yls00 yls00 linked a pull request Jan 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants