You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a function in cborparser.c: cbor_value_text_string_equals which checks if a char array is equal to the cbor value string. It would be helpful to also have this for a byte string, ie:
This can't easily be implemented outside of the cborparser.c file because iterate_string_chunks is a static method contained to just this file.
I am happy to create a PR with this if that would help (I'm also happy to have someone else add it too), but I just wanted to check if this would be accepted?
Thanks.
The text was updated successfully, but these errors were encountered:
That way we don't need to decode to QString in order to compare to
"Keys". There's no avoiding the conversion to it when inserting in the
map for top-level elements, but use of moc's -M option is extremely
rare.
Ideally, we'd simply ask QCborStreamReader to perform a comparison to a
string of ours, so we didn't have to memcpy from the stream in the first
place. But TinyCBOR has no API for that (it's been pending as
intel/tinycbor#223 for a while).
Change-Id: I8bd6bb457b9c42218247fffd1797607f75b153f4
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Hi,
There is a function in
cborparser.c
:cbor_value_text_string_equals
which checks if a char array is equal to the cbor value string. It would be helpful to also have this for a byte string, ie:This can't easily be implemented outside of the
cborparser.c
file becauseiterate_string_chunks
is a static method contained to just this file.I am happy to create a PR with this if that would help (I'm also happy to have someone else add it too), but I just wanted to check if this would be accepted?
Thanks.
The text was updated successfully, but these errors were encountered: