Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track network/conversion fees #2737

Closed
Tracked by #2695
mkurapov opened this issue May 22, 2024 · 3 comments · Fixed by #2831
Closed
Tracked by #2695

Track network/conversion fees #2737

mkurapov opened this issue May 22, 2024 · 3 comments · Fixed by #2831
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented May 22, 2024

Context

We want to track the network/conversion fees that occurred for a particular outgoing payment.
We should have a new metric payment_fees, that is incremented by the following:
outgoingPayment.sentAmount - outgoingPayment.receiveAmount. Both of the amounts need to be converted to a base currency, how we currently do for the transactions_amount metric.

PR:

#2831

@mkurapov mkurapov mentioned this issue May 22, 2024
3 tasks
@mkurapov mkurapov assigned JoblersTune and unassigned mkurapov Jul 9, 2024
@JoblersTune
Copy link
Collaborator

We are going to want to calculate the difference before sending it off.
We had a lot of discussion about trying to differentiate between network fees vs. conversion fees but landed on that being impractical.
Also discussed issue where sender knows currencies but receiver knows final fees.
Set fees (by the ASE) are not included in this metric and are considered more private.
Issue to consider about additional 'fees' coming in when we convert to base currency.

@JoblersTune
Copy link
Collaborator

We'll need to add this info to Grafana for visualisation as well.

@koekiebox
Copy link
Collaborator

Adding link to comment made regarding preservePrivacy:
#2807 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants