Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance? #69

Open
refucktor opened this issue Jan 14, 2020 · 6 comments
Open

Maintenance? #69

refucktor opened this issue Jan 14, 2020 · 6 comments

Comments

@refucktor
Copy link

Hi guys, thanks for your work!!!

Seems like the project is kind of abandoned or maybe you don't have enough time to take care of the issues.

  • Are you accepting PR?
  • Would you recommend to contribute or rather fork the project and provide the necessary changes?
@sangaline
Copy link
Member

We do accept pull requests, but I'm not actively using the project myself right now so this is a relatively low priority for me and it's hard to find time. I've had conversations with a few people about coming on as a maintainer, but they've fallen through. Would you have any interest in being a maintainer?

@refucktor
Copy link
Author

Sorry for my late answer... and thanks for your reply

Unfortunately, I'm kind of running out of time, that's why I have to fork the project and incorporate some adjustments. Our previous setup was using less with antd and at some point, the development process was impossible, from out of memory while recompiling the change to wait minutes until the styles are compiled and the changes refreshed.
I had three main issues with your package:

  1. Packages versions a bit old
  2. Latest sass-loader version compatibility
  3. Webpack resolve.alias compatibility
    WIthout the last one, I have to import the theme with relative path every time and with my proposal, I can use the alias from webpack to resolve the path and inject the style variables.

I would prefer to contribute to your project, cause I see much more value than creating a fork, just at the moment I'm running out of time and the team needs to prepare a big release.

@bmgdev
Copy link

bmgdev commented Apr 2, 2020

@refucktor would you be open to sharing your fork? We're in a similar boat.

@refucktor
Copy link
Author

@bmgdev sure, here is the fork published as npm package @inventium/antd-scss-theme-plugin.

We came out with some pretty stable configuration, let me know if you need any help.

@bmgdev
Copy link

bmgdev commented Apr 3, 2020

@refucktor really appreciate that, thank you!

@MildTomato
Copy link

Is anyone maintaining this project?

@refucktor might have to also use your fork as well 👀 the package warnings keeps coming up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants