Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing uaSymbol on undefined dates #41

Open
eroux opened this issue Sep 27, 2022 · 4 comments
Open

allowing uaSymbol on undefined dates #41

eroux opened this issue Sep 27, 2022 · 4 comments

Comments

@eroux
Copy link

eroux commented Sep 27, 2022

First, thanks for this very useful library!

Currently the code allows 18? to represent "19th century, uncertain", but not 18XX?, as exemplified in this sandbox. I can't really see 18XX? allowed or forbidden in part2 of the draft, but neither can I see 18? forbidden or allowed (even in the grammar at the end)... is there a reason one works and not the other?

@inukshuk
Copy link
Owner

Good question. I don't think that qualified and unspecified dates are supposed to be combined. About the century short-hand I'm not sure either: I guess that it's probably not intended to be qualified either, but the way the API is designed (with Century being a inheriting from the extended date base class) would have meant artificially limiting the interface for the Century sub-class -- I think that's probably why I decided to have the parser accept strings like 18?. In the grammar there are similar reasons: it would probably take more effort to exclude centuries with uncertainty qualifiers than to accept them.

@eroux
Copy link
Author

eroux commented Sep 27, 2022

Thanks for your answer! Do you have contact we could ask about this? Otherwise I think I can ask some people in my network but it will take time

@inukshuk
Copy link
Owner

Sorry, no. Great if you could find out more!

@eroux
Copy link
Author

eroux commented Sep 27, 2022

Ok, I'll keep you updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants