Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For more security spongycastle -> bouncycastle #7

Open
Neustradamus opened this issue May 9, 2020 · 7 comments
Open

For more security spongycastle -> bouncycastle #7

Neustradamus opened this issue May 9, 2020 · 7 comments

Comments

@mcb30
Copy link
Member

mcb30 commented May 9, 2020

I'd be very happy to, but using bouncycastle caused a build failure on Android which is why I switched it in 811148f

If you can get a working gradle build with bouncycastle, please submit a PR and I'll merge it!

@Neustradamus
Copy link
Author

@mcb30
Copy link
Member

mcb30 commented May 9, 2020

Sorry, I wasn't clear. I had to change from bouncycastle to spongycastle in order to get it to build successfully for Android. If you'd like to submit a working PR to change it back, I will happily merge it.

@Neustradamus
Copy link
Author

@mcb30: It is not secure, CVEs, ...

Currently Bouncy Castle last version is 1.65 and Spongy Castle last version is 1.58.
Spongy Castle is a fork of Bouncy Castle.
Please look previous links :)

Since several years, a lot of projects have already moved from Spongy Castle to Bouncy Castle because the project is dead.

You can see discussion "34" in https://github.com/rtyley/spongycastle/issues.

@mcb30
Copy link
Member

mcb30 commented May 10, 2020

@Neustradamus I have absolutely zero objections to switching back to bouncycastle. The problem is that the build fails if I do so. Please submit a PR that fixes the build problem.

@Neustradamus
Copy link
Author

@mcb30: What is the error?

@Neustradamus
Copy link
Author

@mcb30: What is your solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants