Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place argument updates with device affinities fails #18802

Open
sogartar opened this issue Oct 16, 2024 · 1 comment
Open

In-place argument updates with device affinities fails #18802

sogartar opened this issue Oct 16, 2024 · 1 comment
Labels
bug 🐞 Something isn't working

Comments

@sogartar
Copy link
Contributor

sogartar commented Oct 16, 2024

What happened?

This program in-place-sharded-tensor.zip fails to do a proper in-place update.

The program is equivalent to

arg0 += 1
arg1 += 1

What I observe is that the 2 tensor arguments don't change.
It is exported from the test ShardedTensorTest.testInPlaceUpdate from this PR.

Steps to reproduce your issue

  1. Extract the archive and run compile.sh
  2. You can't verify the result with iree-run-module as it does not support validating the arguments post execution. You can use the test from the referenced PR for that.

What component(s) does this issue relate to?

Compiler

Version information

You may need this patch. I was using it when testing.

Additional context

No response

@sogartar sogartar added the bug 🐞 Something isn't working label Oct 16, 2024
@sogartar
Copy link
Contributor Author

sogartar commented Oct 22, 2024

I found one of the problems #18870. It is in the Python bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant