Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VectorDistribute] Zero dimensional vectors causing distribution failure in VectorDistribute #18955

Open
Max191 opened this issue Oct 30, 2024 · 0 comments
Assignees

Comments

@Max191
Copy link
Contributor

Max191 commented Oct 30, 2024

A new change in mlir (llvm/llvm-project@1004865#diff-51a55079ee1ee8936812c5be30869c89451372a0c675ff80ff739998c494e806L750) introduces zero dimensional vector transfers, which causes VectorDistribute to break later on. The change is reverted for now, but we need to fix the bug to reapply the patch.

Repro

The following gist contains an executable benchmark and a compile command for reproducing the failure:

https://gist.github.com/Max191/8a110c7eb192377c5f0665a14382f2b6

  • Checkout https://github.com/Max191/iree/tree/zero-d-vecdist
  • run the command at the top of the above gist file: iree-compile test.mlir --compile-from=executable-sources --iree-hal-target-backends=rocm --iree-hip-target=gfx942 --iree-input-demote-f64-to-f32 -o /tmp/z.vmfb

Pass Repro

The gist also includes a smaller pass reproducer of just the VectorDistribute pass that fails:

  • run iree-opt --pass-pipeline="builtin.module(func.func(iree-llvmgpu-vector-distribute))" pass_repro.mlir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants