Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.objects.all() does not convert types in primary keys #147

Open
jacebrowning opened this issue Dec 26, 2019 · 2 comments
Open

Model.objects.all() does not convert types in primary keys #147

jacebrowning opened this issue Dec 26, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jacebrowning
Copy link
Owner

jacebrowning commented Dec 26, 2019

See this test reproducing the failure:

def test_values_are_filled_from_disk(expect):
InventoryItem.objects.get_or_create(42, "Things", 0.99)
items = list(InventoryItem.objects.all())
expect(items[0]) == InventoryItem(42, "Things", 0.99)

@jacebrowning jacebrowning added the bug Something isn't working label Dec 26, 2019
@jacebrowning jacebrowning added the help wanted Extra attention is needed label Apr 13, 2020
@nielslerches
Copy link

Hi,

Is this issue still relevant?

If so, I'd like to take a crack at solving the issue, as I have a potential use case for this feature.

@jacebrowning
Copy link
Owner Author

@nielslerches yes, it's still an issue. You can confirm that by removing the xfail marker to see the test fail.

Let me know if you have any more questions!

nielslerches added a commit to nielslerches/datafiles that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants