Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new benchmarking mode to multiprocessing #145

Open
buerokrata opened this issue Jun 29, 2016 · 2 comments
Open

Adding a new benchmarking mode to multiprocessing #145

buerokrata opened this issue Jun 29, 2016 · 2 comments
Assignees

Comments

@buerokrata
Copy link

Would it be feasible to add a "Pattern" mode to the target series options in the benchmarking specification field? Like this external constraints could be used (not just tranformations of the raw series), a Regex pattern may instruct the time-series provider how to pick up the constraint series. I'd be happy to contribute to the development, if you feel this is feasible, and does not stretch to much the possibilities of the current model.

@buerokrata
Copy link
Author

Dear core team,
On further reflection it may be difficult to generalize this feature (I will try to make an OECD/provider- specific plugin). Although the "only" thing I would like to do is to extend the BenchmarkSpecification, and make sure that the constraint data is picked up from the same provider as the original data, it seems to me that I will have to go all the way up in the object tree and start re-writing the "MultiprocessingDocFileRepository", and then everything underneath. Let me know if you think there is a more economical entry point than this. I found a couple of objects/classes where my first idea was to just implement them in my alternate version, but they were lacking either public constructors or some key methods were not callable from outside the package (as they were not public), perhaps on purpose. Let me know if you have some time to discuss any of this. Thanks Gy.

@charphi
Copy link
Contributor

charphi commented Sep 8, 2016

Ok, I will take a look at this problem.

@charphi charphi self-assigned this Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants