-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing Hex package compilation #209
Comments
Try patching it to So it would be the best to target it there. |
Great, thanks for the quick response! I've just opened the PR. |
CI passes. I've also added a hint to the Hex package in the README, since that info is a bit hard to find. Let me know if you'd prefer to have it changed or removed again :) |
I actually found an even better solution, I think, at least for Elixir: def deps do
[
{:graphql, "~> 0.16.0", hex: :graphql_erl}
]
end My only experience is with Elixir though, for which this works fine. Would it still be helpful for erlang or other BEAM languages to use relative paths for header files? 🤔 |
As there doesn't seem to be a need to make the include paths relative, I've closed that PR. If you don't mind, a new release to hex would be greatly appreciated as well. Lastly, setting the master branch as default could also help people new to the project see what's going on. Thanks so much for the great work! ❤️ |
Having the same issue trying to add it to the Erlang project. Seems indeed it's because of the name in hex and in the app.src doesn't match.
|
Hi there,
when getting the Hex package, compilation fails with the following log:
To debug, I set the git commit of the Hex release (3ea1b3a) in mix.lock in combination with each of the following entries in mix.exs:
As only the 1. works, I assumed the changed package name on hex is an issue.
So I went ahead and replaced all occurrences of
graphql/include/
withgraphql_erl/include/
and could compile the hex-installed package that way 🎉Then I replaced these with
../include/
and found that this works as well. So I guess that would be a solution for both hex and non-hex installed compilations?Would you accept a PR with this change? If yes, which branch should I base it off?
Thanks for the great work and all the best,
Arno
The text was updated successfully, but these errors were encountered: