-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout causes unhandled exception to be thrown #13
Comments
Hello @phawxby, are you able to create a Pull Request for this improvement? 🙏🏼 |
I'll quickly throw something together now. I'm having to do some research because as noted here it's a secret how the callback is supposed to be used. So I'm basically going to copy this. |
Version 1.1.0 published |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
winston-newrelic-logs-transport/index.ts
Lines 29 to 33 in d1ff186
As the call to NewRelic is an async operation that is not awaited or handled in a callback if the request times out then an unhandled error is thrown. It would also be good if it were possible to increase the timeout or supply additional options.
The text was updated successfully, but these errors were encountered: