Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some metrics are no longer available during the server shutdown delay #117

Open
keydam opened this issue Mar 1, 2023 · 1 comment
Open

Some metrics are no longer available during the server shutdown delay #117

keydam opened this issue Mar 1, 2023 · 1 comment

Comments

@keydam
Copy link
Contributor

keydam commented Mar 1, 2023

Hi there,

Sorry I think I found another bug ..

When the test is done and Jmeter is waiting for the server to close, the metrics about the requests aren't available anymore . Only the ones about the JVM are ..

The good news is it's easy to patch ..
We just need to edit the method "com.github.johrstrom.listener.PrometheusListener.testEnded()" to put the clearing part after the closing of the server.

I can make a pull request if it's OK for you.

Damien
@johrstrom
Copy link
Owner

I can make a pull request if it's OK for you.

Pull requests are always welcome!

johrstrom pushed a commit that referenced this issue Mar 2, 2023
@keydam
Pull request concerning issue #117 (#118)
5e567b3 
* bugfix in PrometheusServer.java to close the server after the delay

* bugfix in PrometheusListener.java to clear the collectors after the server is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johrstrom @keydam